Skip to content

Privatize zlib + friends; build shared on windows [alt.]#246

Closed
h-vetinari wants to merge 16 commits intoconda-forge:mainfrom
h-vetinari:private_isuru
Closed

Privatize zlib + friends; build shared on windows [alt.]#246
h-vetinari wants to merge 16 commits intoconda-forge:mainfrom
h-vetinari:private_isuru

Conversation

@h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Sep 23, 2022

Alternative to #243.

@conda-forge-linter
Copy link

conda-forge-linter commented Sep 23, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Sep 23, 2022
Merged
@h-vetinari
Copy link
Member Author

h-vetinari commented Sep 23, 2022

Github got confused with having CI for the same commit run from two PRs (one cancelled), but in any case, the new run is there.

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 22, 2022 •
edited
Loading

Sidenote: The CI is running, GH just gets confused with the same commit having been cancelled in another PR.

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 22, 2022 •
edited
Loading

@isuruf, thanks for tackling the Fork bits as well, but it looks like it's not working yet (I might try bashing on it later based on what you started with).

D:\bld\grpc-split_1666422622638\work\src\core\lib\gprpp\fork.cc(252): error C2039: 'support_enabled_': is not a member of 'grpc_core::Fork'
D:\bld\grpc-split_1666422622638\work\src/core/lib/gprpp/fork.h(38): note: see declaration of 'grpc_core::Fork'
D:\bld\grpc-split_1666422622638\work\src\core\lib\gprpp\fork.cc(252): error C2374: 'grpc_core::support_enabled_': redefinition; multiple initialization
D:\bld\grpc-split_1666422622638\work\src\core\lib\gprpp\fork.cc(166): note: see declaration of 'grpc_core::support_enabled_'

@h-vetinari h-vetinari deleted the private_isuru branch May 24, 2023 02:06
@h-vetinari h-vetinari mentioned this pull request Feb 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohanMabille JohanMabille Awaiting requested review from JohanMabille JohanMabille will be requested when the pull request is marked ready for review JohanMabille is a code owner

@jjerphan jjerphan Awaiting requested review from jjerphan jjerphan will be requested when the pull request is marked ready for review jjerphan is a code owner

@mariusvniekerk mariusvniekerk Awaiting requested review from mariusvniekerk mariusvniekerk will be requested when the pull request is marked ready for review mariusvniekerk is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou will be requested when the pull request is marked ready for review pitrou is a code owner

@wesm wesm Awaiting requested review from wesm wesm will be requested when the pull request is marked ready for review wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy will be requested when the pull request is marked ready for review xhochy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@h-vetinari @conda-forge-linter @isuruf