Skip to content

Remove abseil from linkage again; correct pkgconfig metadata for privatized libs; add tests#237

Closed
h-vetinari wants to merge 23 commits intoconda-forge:1.46.xfrom
h-vetinari:link
Closed

Remove abseil from linkage again; correct pkgconfig metadata for privatized libs; add tests#237
h-vetinari wants to merge 23 commits intoconda-forge:1.46.xfrom
h-vetinari:link

Conversation

@h-vetinari
Copy link
Member

Follow-up to #213 / #236

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Surprisingly, the shared builds on windows get pretty far actually... Only one shared symbol missing when linking (the vendored) upb library

[1154/1194] Linking C shared library upb.dll
[1155/1194] Building CXX object CMakeFiles\gen_hpack_tables.dir\tools\codegen\core\gen_hpack_tables.cc.obj
[1156/1194] Linking CXX shared library gpr.dll
FAILED: gpr.dll gpr.lib 
cmd.exe /C "cmd.exe /C "D:\bld\grpc-split_1662214772855\_build_env\Library\bin\cmake.exe -E __create_def D:\bld\grpc-split_1662214772855\work\build-cpp\CMakeFiles\gpr.dir\.\exports.def D:\bld\grpc-split_1662214772855\work\build-cpp\CMakeFiles\gpr.dir\.\exports.def.objs && cd D:\bld\grpc-split_1662214772855\work\build-cpp" && D:\bld\grpc-split_1662214772855\_build_env\Library\bin\cmake.exe -E vs_link_dll --intdir=CMakeFiles\gpr.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\gpr.rsp  /out:gpr.dll /implib:gpr.lib /pdb:gpr.pdb /dll /version:24.0 /machine:x64 /INCREMENTAL:NO  /DEF:CMakeFiles\gpr.dir\.\exports.def  && cd ."
LINK: command "C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\gpr.rsp /out:gpr.dll /implib:gpr.lib /pdb:gpr.pdb /dll /version:24.0 /machine:x64 /INCREMENTAL:NO /DEF:CMakeFiles\gpr.dir\.\exports.def /MANIFEST /MANIFESTFILE:gpr.dll.manifest" failed (exit code 1120) with the following output:
   Creating library gpr.lib and object gpr.exp
status_helper.cc.obj : error LNK2019: unresolved external symbol upb_alloc_global referenced in function "public: __cdecl upb::Arena::Arena(void)" (??0Arena@upb@@QEAA@XZ)

Not sure what's special about upb_alloc_global.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants