Split feedstock into astropy-base and astropy packages and update to 7.0 by Cadair · Pull Request #137 · conda-forge/astropy-feedstock

Cadair · 2024-06-11T13:02:37Z

This PR adds a new package astropy-base with just the required dependencies and updates the astropy package to have almost all the optional dependencies.

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-webservices · 2024-06-11T13:02:45Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

conda-forge-webservices · 2024-06-11T13:03:57Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Cadair · 2024-06-11T13:04:19Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.06.11.11.32.55

Co-authored-by: Clément Robert <cr52@protonmail.com>

conda-forge-webservices · 2024-09-11T14:15:40Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

astrofrog

We should definitely do this!

…rything*

conda-forge-webservices · 2024-09-11T14:53:30Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices · 2024-09-11T14:54:47Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-webservices · 2024-09-17T12:24:39Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-admin · 2024-11-26T11:39:30Z

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12029783733. Examine the logs at this URL for more detail.}

conda-forge-admin · 2024-11-26T11:56:31Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12030193387. Examine the logs at this URL for more detail.}

…nda-forge-pinning 2024.11.26.07.33.56

conda-forge-admin · 2024-11-26T12:16:12Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [82]

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12030369091. Examine the logs at this URL for more detail.}

conda-forge-admin · 2024-11-26T12:18:56Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12030413883. Examine the logs at this URL for more detail.}

conda-forge-admin · 2024-11-26T12:25:12Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

bsipocz · 2024-11-26T12:25:49Z

🍿 - I'm glad it's not me driving this PR 😄

Cadair · 2024-11-26T12:26:10Z

😭

Cadair · 2024-11-26T12:32:24Z

Just to make sure:

@conda-forge-admin, please rerender

…onda-forge-pinning 2024.11.26.07.33.56

bsipocz · 2024-11-26T13:03:54Z

    test(package='wcs')
    test(package='io.fits')
 else:
-    test()


Ahh, this is a good reminder that we actually use the testmodule

It would be easy to not and invoke pytest here

Cadair · 2024-11-26T13:26:06Z

Oh my god I think this is ready.

bsipocz · 2024-11-26T13:29:32Z

@Cadair - do you want to cleanup, or shall I squash merge, or yolo? Happy with either options :)

Cadair · 2024-11-26T13:30:04Z

Happy to squash merge it. Rebasing was unappealing.

mwcraig · 2024-11-26T13:31:30Z

Thanks for bringing this one to completion!

bsipocz · 2024-11-26T13:35:02Z

Hurray 🎆

Cadair force-pushed the deps branch from 3bd4a5b to cdfc2ec Compare June 11, 2024 13:03

include recommended deps

10f25d5

Cadair force-pushed the deps branch from cdfc2ec to 10f25d5 Compare June 11, 2024 13:04

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.1, and co…

19f0602

…nda-forge-pinning 2024.06.11.11.32.55

neutrinoceros reviewed Jun 11, 2024

View reviewed changes

Comment thread recipe/meta.yaml Outdated

This was referenced Jun 11, 2024

DEP: update minimal recommendation for matplotlib (3.3.4 -> 3.6.0) astropy/astropy#16557

Merged

APE23: Guidelines for required and optional dependencies astropy/astropy-APEs#86

Draft

Cadair mentioned this pull request Sep 11, 2024

Rework Install guide following on from #16555 astropy/astropy#16987

Merged

1 task

Update recipe/meta.yaml

b587d99

Co-authored-by: Clément Robert <cr52@protonmail.com>

astrofrog approved these changes Sep 11, 2024

View reviewed changes

neutrinoceros mentioned this pull request Sep 11, 2024

DEP: bump minimum requirement for matplotlib for astropy 6.1.x astropy/astropy#16993

Merged

1 task

Build a astropy-base with only recommended deps and astropy with *eve…

46cb750

…rything*

Merge branch 'main' into deps

132a0b0

Try again

f7adcc6

bsipocz reviewed Sep 11, 2024

View reviewed changes

Comment thread recipe/meta.yaml Outdated

Cadair added 4 commits September 11, 2024 16:28

and another

9c37e90

Alright let's see if we can build -base for 3.13 but not astropy

581c5fc

Ok clearly mpl isn't ready for 3.13

9b566fb

circular deps are bad

3545433

pllim reviewed Sep 11, 2024

View reviewed changes

Comment thread recipe/meta.yaml Outdated

pllim reviewed Sep 11, 2024

View reviewed changes

Comment thread recipe/meta.yaml

Cadair mentioned this pull request Sep 12, 2024

Add astropy-base recipie for an astropy package with minimal deps conda-forge/staged-recipes#27563

Closed

10 tasks

Take another crack at this

6cd686c

Cadair added 2 commits November 25, 2024 16:02

Fallback on windows I guess

800e30c

See if noarch: python works

56f9f14

Cadair force-pushed the deps branch from cb00a45 to 8701254 Compare November 26, 2024 12:04

lint and test script.

31a2672

Cadair force-pushed the deps branch from 8701254 to 31a2672 Compare November 26, 2024 12:04

Cadair added 2 commits November 26, 2024 12:08

MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.44.7, and co…

000b0c6

…nda-forge-pinning 2024.11.26.07.33.56

skip you say 😭

87b7f86

revert skip (╯°□°）╯︵ ┻━┻

b221eb2

Oh my sainted trousers

8d6a1cb

conda-forge-webservices[bot] and others added 2 commits November 26, 2024 12:34

MNT: Re-rendered with conda-build 24.11.1, conda-smithy 3.44.7, and c…

4b4fb68

…onda-forge-pinning 2024.11.26.07.33.56

Run less tests

6177fc3

bsipocz reviewed Nov 26, 2024

View reviewed changes

bsipocz merged commit 81efe47 into conda-forge:main Nov 26, 2024

Cadair deleted the deps branch November 26, 2024 14:05

pllim mentioned this pull request Dec 24, 2024

Cannot import astropy.time (7.0.0) astropy/astropy#17580

Closed

keewis mentioned this pull request Feb 14, 2025

ENH: split xarray into multi-ouput conda-forge/xarray-feedstock#113

Draft

5 tasks

pllim mentioned this pull request Mar 10, 2025

Suggestion: depend on astropy-base instead of astropy conda-forge/asdf-astropy-feedstock#14

Merged

Uh oh!

Uh oh!

Conversation

Cadair commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-webservices Bot commented Jun 11, 2024

Uh oh!

conda-forge-webservices Bot commented Jun 11, 2024

Uh oh!

Cadair commented Jun 11, 2024

Uh oh!

Uh oh!

conda-forge-webservices Bot commented Sep 11, 2024

Uh oh!

astrofrog left a comment

Choose a reason for hiding this comment

Uh oh!

conda-forge-webservices Bot commented Sep 11, 2024

Uh oh!

conda-forge-webservices Bot commented Sep 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

conda-forge-webservices Bot commented Sep 17, 2024

Uh oh!

conda-forge-admin commented Nov 26, 2024

Uh oh!

conda-forge-admin commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-admin commented Nov 26, 2024

Uh oh!

conda-forge-admin commented Nov 26, 2024

Uh oh!

conda-forge-admin commented Nov 26, 2024

Uh oh!

bsipocz commented Nov 26, 2024

Uh oh!

Cadair commented Nov 26, 2024

Uh oh!

Cadair commented Nov 26, 2024

Uh oh!

bsipocz Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

Cadair Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

Cadair commented Nov 26, 2024

Uh oh!

bsipocz commented Nov 26, 2024

Uh oh!

Cadair commented Nov 26, 2024

Uh oh!

mwcraig commented Nov 26, 2024

Uh oh!

bsipocz commented Nov 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Cadair commented Jun 11, 2024 •

edited

Loading

conda-forge-admin commented Nov 26, 2024 •

edited

Loading