Skip to content

arrow 14.0.0 with new setup (more granular libraries; no more legacy outputs)#1201

Merged
github-actions[bot] merged 16 commits intoconda-forge:mainfrom
h-vetinari:14_split
Nov 7, 2023
Merged

arrow 14.0.0 with new setup (more granular libraries; no more legacy outputs)#1201
github-actions[bot] merged 16 commits intoconda-forge:mainfrom
h-vetinari:14_split

Conversation

@h-vetinari
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari commented Oct 14, 2023

Combines #1170 with a slimmed-down version of #1175

Closes #1035
Closes #1170
Closes #1175
Closes #1218

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libarrow-all' output doesn't have any tests.

@h-vetinari h-vetinari force-pushed the 14_split branch 4 times, most recently from 3685764 to efb4224 Compare October 16, 2023 02:52
@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge conda-forge deleted a comment from conda-forge-webservices bot Oct 16, 2023
@h-vetinari h-vetinari force-pushed the 14_split branch 3 times, most recently from 6170f32 to 6173572 Compare October 16, 2023 04:02
@conda-forge conda-forge deleted a comment from conda-forge-webservices bot Oct 16, 2023
@h-vetinari h-vetinari force-pushed the 14_split branch 3 times, most recently from 9a36abb to 74cecc8 Compare October 16, 2023 12:41
@h-vetinari h-vetinari mentioned this pull request Nov 1, 2023
3 tasks
@h-vetinari h-vetinari changed the title WIP: arrow 14 with component split arrow 14.0.0 with new setup (more granular libraries; no more legacy outputs) Nov 1, 2023
@h-vetinari h-vetinari marked this pull request as ready for review November 1, 2023 07:53
Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are probably ways to speed up the build a bit but from the content-perspective, this PR looks good to me.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Nov 7, 2023
@h-vetinari
Copy link
Copy Markdown
Member Author

Thanks for the review! :)

@github-actions github-actions bot merged commit 3eaea8a into conda-forge:main Nov 7, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jorisvandenbossche
Copy link
Copy Markdown
Member

jorisvandenbossche commented Nov 9, 2023

@h-vetinari thanks a lot for finishing this splitting! Based on a quick test, this seems to be working fine

As a follow-up, should we add a pyarrow-base or pyarrow-core (I think both suffixes are being used) that only depends on libarrow?

@raulcd
Copy link
Copy Markdown
Member

raulcd commented Nov 9, 2023

I was planning on trying to work on this during the next couple of weeks now that this has been merged and I have released 14.0.1.

@h-vetinari h-vetinari deleted the 14_split branch November 9, 2023 22:36
@h-vetinari
Copy link
Copy Markdown
Member Author

As a follow-up, should we add a pyarrow-base or pyarrow-core (I think both suffixes are being used) that only depends on libarrow?

Based on discussion in apache/arrow#38536 and the work towards that which went into arrow 14 already, I think we should definitely try!

I was planning on trying to work on this during the next couple of weeks now that this has been merged and I have released 14.0.1.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package some form of "minimal" libarrow?

5 participants