fix(menuinst): respect user-provided CFBundleIdentifier in macOS Info.plist#1887
Merged
wolfv merged 1 commit intoconda:mainfrom Nov 25, 2025
Conversation
….plist
The CFBundleIdentifier field was defined in the schema and could be
specified in menu.json files, but the code always generated a default
value using `com.{slugname}` instead of using the user-provided value.
This fix changes the behavior to:
1. Use the user-provided CFBundleIdentifier from menu.json if specified
2. Fall back to the default `com.{slugname}` format if not specified
3. For AppKit launcher bundles, append `-appkit-launcher` to the
resolved identifier
Fixes conda#1886
Collaborator
Author
|
@wolfv can you maybe verify locally on you mac if this fixes the issue? |
Contributor
|
Thanks! Looks good :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CFBundleIdentifier field was defined in the schema and could be specified in menu.json files, but the code always generated a default value using
com.{slugname}instead of using the user-provided value.This fix changes the behavior to:
com.{slugname}format if not specified-appkit-launcherto the resolved identifierFixes #1886