Enable the menu name to depends on the folder name of the root prefix#77
Merged
cjmartian merged 1 commit intoconda:masterfrom Apr 1, 2021
Merged
Conversation
Contributor
|
@chenghlee, @cjmartian can you review this? |
cjmartian
approved these changes
Apr 1, 2021
chenghlee
approved these changes
Apr 1, 2021
Merged
Contributor
Author
|
Thanks @cjmartian and @chenghlee for the review. I have edited the wiki accordingly: https://github.com/ContinuumIO/menuinst/wiki/Menu-Shortcut-Config-Structure/_compare/632fbc84251c8a8093e1b56b0b5314d23c1e946b |
Closed
6 tasks
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the name of the menu needs to be defined in the shortcu config json, which indirectly makes the conda recipe specific to a distribution.
The idea of this PR is to use the name of the distribution (Anaconda, Miniconda, Miniforge, etc.) as the name of the menu in the start menu. The name of the folder of the root prefix is used to determine the name of the distribution - this is the case by default. I am not aware of a better way to get the name of the distribution.
This PR is primarily for https://github.com/conda-forge/miniforge_console_shortcut-feedstock/blob/master/recipe/console_shortcut.json, and with this PR, its shortcut config could be changed to:
More generally, this would also be useful for other conda-forge recipes (spyder, notebook, etc.)