Skip to content

Add support of MySQL 8 keywords#6753

Merged
aembler merged 3 commits intoconcretecms:developfrom
mlocati-forks:mysql8-driver
Jun 11, 2018
Merged

Add support of MySQL 8 keywords#6753
aembler merged 3 commits intoconcretecms:developfrom
mlocati-forks:mysql8-driver

Conversation

@mlocati
Copy link
Copy Markdown
Contributor

@mlocati mlocati commented Jun 9, 2018

#6622 is not enough to close #6156: we need to tell Doctrine the actual list of MySQL reserved keywords.

Since doctrine/dbal#3128 won't be backported, we have to implement our own MySQL 8 reserved keyword list.

Fix #6156

@mlocati
Copy link
Copy Markdown
Contributor Author

mlocati commented Jun 11, 2018

I just tested a clean installation with MySQL 8, end everything seems to work as expected.

@aembler aembler merged commit 68791c3 into concretecms:develop Jun 11, 2018
@aembler
Copy link
Copy Markdown
Member

aembler commented Jun 11, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groups is a reserved keyword in MySQL 8

2 participants