Skip to content

Add editor plugin descriptions and configuration preview#6720

Merged
aembler merged 5 commits intoconcretecms:developfrom
mlocati-forks:editor-plugins-description-and-preview
Jun 7, 2018
Merged

Add editor plugin descriptions and configuration preview#6720
aembler merged 5 commits intoconcretecms:developfrom
mlocati-forks:editor-plugins-description-and-preview

Conversation

@mlocati
Copy link
Copy Markdown
Contributor

@mlocati mlocati commented Jun 4, 2018

This is the implementation of what I showcased in #6717.

@mlocati mlocati mentioned this pull request Jun 4, 2018
@mlocati mlocati force-pushed the editor-plugins-description-and-preview branch from 9e039e6 to 21cce5b Compare June 6, 2018 07:15
@mlocati
Copy link
Copy Markdown
Contributor Author

mlocati commented Jun 6, 2018

I updated the way the preview is shown:
Editor Preview

'undo' => [t('Undo'), t('This plugin provides the undo and redo features.')],
// https://ckeditor.com/cke4/addon/wsc
'wsc' => [t('WebSpellChecker'), t('This plugin brings spell checking in a dialog window into the editor.')],
'wsc' => [t('WebSpellChecker'), t('This plugin privides a dialog window for spell checking.')],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a typo -> provides

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@aembler aembler merged commit cac63d2 into concretecms:develop Jun 7, 2018
@mlocati mlocati deleted the editor-plugins-description-and-preview branch June 7, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants