Skip to content

cgal: add cgal/6.0#25637

Merged
conan-center-bot merged 3 commits intoconan-io:masterfrom
lrineau:cgal-6.0
Oct 28, 2024
Merged

cgal: add cgal/6.0#25637
conan-center-bot merged 3 commits intoconan-io:masterfrom
lrineau:cgal-6.0

Conversation

@lrineau
Copy link
Copy Markdown
Contributor

@lrineau lrineau commented Oct 16, 2024

Summary

Changes to recipe: cgal/6.0

Resolves #25050.

Motivation

New upstream release: CGAL version 6.0, https://github.com/CGAL/cgal/releases/tag/v6.0

Details

CGAL 6.0 has a few breaking changes. The major one is that C++17 or later is now required (instead of C++14 for version 5.6).

Also: the PR CGAL/cgal#7512 is merged in CGAL-6.0. That changes the creation of the file lib/cmake/CGAL/conan-official-cgal-variables.cmake, that is now simpler:

include(${CMAKE_CURRENT_LIST_DIR}/CGAL_SetupCGALDependencies.cmake)
CGAL_setup_CGAL_flags(CGAL::CGAL)

# CGAL use may rely on the presence of those two variables
set(CGAL_USE_GMP  TRUE CACHE INTERNAL "CGAL library is configured to use GMP")
set(CGAL_USE_MPFR TRUE CACHE INTERNAL "CGAL library is configured to use MPFR")

@lrineau lrineau mentioned this pull request Oct 16, 2024
Open
@lrineau lrineau changed the title Cgal 6.0 cgal: add cgal/6.0 Oct 16, 2024
@lrineau lrineau mentioned this pull request Oct 16, 2024
Closed
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 16, 2024
Closed
Closed
@lrineau lrineau marked this pull request as ready for review October 16, 2024 22:05
@conan-center-bot
Copy link
Copy Markdown
Contributor

conan-center-bot commented Oct 16, 2024

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (d798cb03831359e879a8ca48dd1591b1321c3a4e):

  • cgal/5.3.2:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5.2:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5.1:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5.3:
    Built 5 packages out of 11 (All logs)

  • cgal/6.0:
    Built 5 packages out of 11 (All logs)

  • cgal/5.6.1:
    Built 5 packages out of 11 (All logs)

  • cgal/5.6:
    Built 5 packages out of 11 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (d798cb03831359e879a8ca48dd1591b1321c3a4e):

  • cgal/5.3.2:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5.1:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5.2:
    Built 4 packages out of 5 (All logs)

  • cgal/5.6:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5.3:
    Built 4 packages out of 5 (All logs)

  • cgal/5.6.1:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5:
    Built 4 packages out of 5 (All logs)

  • cgal/6.0:
    Built 4 packages out of 5 (All logs)

@AbrilRBS AbrilRBS self-assigned this Oct 17, 2024
@lrineau
Copy link
Copy Markdown
Contributor Author

lrineau commented Oct 17, 2024

Hi @AbrilRBS. Let me know if there is anything I should do about this PR. I am unsure about the PR #25050, that adds cgal/6.0-beta1. This one is about cgal/6.0, the official release.

AbrilRBS
AbrilRBS approved these changes Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! We appreciate you taking the time to create the PR for the new release :)

@lrineau
Copy link
Copy Markdown
Contributor Author

lrineau commented Oct 28, 2024

Hi, two weeks later, is there anything blocking this pull-request? @AbrilRBS, do you know?

CGAL-6.0.1 has been published, last week. But I would prefer this PR be merged before I contribute cgal/6.0.1 in another PR.

Or should I add cgal/6.0.1 it to this one?

uilianries
uilianries approved these changes Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for updating the recipe as well and congrats for the new major release!

@uilianries
Copy link
Copy Markdown
Member

uilianries commented Oct 28, 2024

Hi, two weeks later, is there anything blocking this pull-request? @AbrilRBS, do you know?

CGAL-6.0.1 has been published, last week. But I would prefer this PR be merged before I contribute cgal/6.0.1 in another PR.

Or should I add cgal/6.0.1 it to this one?

@lrineau Yes, you can add to this PR as well, or just replace the current 6.0 by 6.0.1, as people should consume the latest version available as preferable.

@conan-center-bot conan-center-bot merged commit 6e1084e into conan-io:master Oct 28, 2024
@lrineau lrineau deleted the cgal-6.0 branch October 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lrineau @conan-center-bot @uilianries @AbrilRBS