Closed
Conversation
|
It solved my problem! |
|
A more constructive feedback: the package array is merged before the dumpDownloads call, which means that the full list of package will be dumped. |
Member
There was a problem hiding this comment.
Instead of creating a VCS repo like this, I think it should pick one by name (the repositories array can be a json object with names for every repo), number (zero based if you used a plain array for repos) or maybe if you give an url that it looks in the original definition for a repo with the given URL. Otherwise some settings might be lost, not everyone defines their repo with only vcs+url.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a quick hackish implementation of #40. I've opened the pull request as a starting point to discuss a better way of adding this feature. All feedback is appreciated :)