Fix validate strict warnings#8605
Merged
Seldaek merged 8 commits intocomposer:masterfrom Feb 14, 2020
guilliamxavier:fix-validate-strict-warnings
Merged
Fix validate strict warnings#8605Seldaek merged 8 commits intocomposer:masterfrom guilliamxavier:fix-validate-strict-warnings
Seldaek merged 8 commits intocomposer:masterfrom
guilliamxavier:fix-validate-strict-warnings
Conversation
Seldaek
reviewed
Feb 14, 2020
Seldaek
reviewed
Feb 14, 2020
guilliamxavier
commented
Feb 14, 2020
Contributor
Author
guilliamxavier
left a comment
There was a problem hiding this comment.
@Seldaek: Thanks, you are right, and made me realize that actually it was useless to add $publishErrors/$lockErrors to $warnings (modified by reference) in the !$isStrict case (because it won't be checked).
Also, instead of adding to a copy, we could add to an empty array and merge at the end (see the list of Suggested changes below), which one do you prefer?
Co-Authored-By: Guilliam Xavier <guilliamxavier@users.noreply.github.com>
Member
|
Yup thanks that is easier to follow I think |
Contributor
Author
|
Oops I had forgotten PHP 5.3, sorry, fixed |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validatecommand: with--no-check-publish, adding--strictmakes warnings disappear from output #8602