splitstream: Add more unit tests#206
Merged
jeckersb merged 1 commit intocomposefs:mainfrom Jan 8, 2026
Merged
Conversation
While a lot of the splitstream code is *indirectly* tested through unit and integration tests for higher level things, let's add dedicated unit tests here to it as well; the cost (execution time, text) is pretty small vs the value. Note that splitstream has a circular dependency vs Repository; we discussed severing that, but after looking at an attempt to do so it adds a lot of complexity that I think worsens the calculus. Assisted-by: OpenCode (Opus 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a lot of the splitstream code is indirectly tested through unit and integration tests for higher level things, let's add dedicated unit tests here to it as well; the cost (execution time, text) is pretty small vs the value.
Note that splitstream has a circular dependency vs Repository; we discussed severing that, but after looking at an attempt to do so it adds a lot of complexity that I think worsens the calculus.
Assisted-by: OpenCode (Opus 4.5)