introduce dockerfile-inline#315
Merged
glours merged 1 commit intocompose-spec:masterfrom Mar 13, 2023
Merged
Conversation
3cabd48 to
7b6af62
Compare
EricHripko
reviewed
Mar 5, 2023
Collaborator
|
The proposal makes sense - I was wondering if we could let |
316d172 to
bcf92e5
Compare
Collaborator
Author
Yes, I expect this could bring some weird issues, so better use an explicit attribute. We could later investigate introducing more magic |
bcf92e5 to
caaf61a
Compare
glours
reviewed
Mar 13, 2023
laurazard
approved these changes
Mar 13, 2023
Member
laurazard
left a comment
There was a problem hiding this comment.
A bit sad about not having the custom yaml type, but it's probably for the best 😞
LGTM ✅
fbd0480 to
c87aef4
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
c87aef4 to
2d5fe4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
define
dockerfile_inlinefor user to declare a (simple) Dockerfile as inlined content directly in a compose-file.attribute named has been chosen to align with bake's dockerfile-inline https://docs.docker.com/build/bake/file-definition/ but using underscore separator for consistency with other attributes
Which issue(s) this PR fixes:
Fixes #298