Add additional_contexts to build section#307
Merged
ndeloof merged 1 commit intocompose-spec:masterfrom Mar 13, 2023
Merged
Conversation
ndeloof
approved these changes
Feb 16, 2023
milas
reviewed
Feb 17, 2023
Member
milas
left a comment
There was a problem hiding this comment.
This makes sense to me! Interested to hear thoughts from @tonistiigi @crazy-max @jedevc
eaa2f31 to
2fc44ef
Compare
crazy-max
reviewed
Feb 17, 2023
EricHripko
approved these changes
Feb 19, 2023
Collaborator
EricHripko
left a comment
There was a problem hiding this comment.
Sounds good ✅ Thank you for putting this together 🙌
120ac92 to
8d1678f
Compare
glours
approved these changes
Feb 19, 2023
Contributor
glours
left a comment
There was a problem hiding this comment.
Sounds good to me, maybe adding a hint when the constructor doesn't support additional contexts could be a great addition
8d1678f to
fb467c4
Compare
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
fb467c4 to
139b322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for configuring additional/named contexts in the
buildsection.Which issue(s) this PR fixes:
Fixes #306