Added volume bind option SELinux :z :Z#221
Merged
ndeloof merged 4 commits intocompose-spec:masterfrom Jan 7, 2022
Merged
Conversation
Related with compose-spec/compose-go#213 This feature describe the SELinux field for setting the :z or :Z bind option for relabeling SELinux label. It fixes compose-spec#191 References: - https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
EricHripko
reviewed
Jan 7, 2022
Collaborator
EricHripko
left a comment
There was a problem hiding this comment.
Thank you for putting this together! I got a small suggestion inline 💬
spec.md
Outdated
|
|
||
| `VOLUME` MAY be either a host path on the platform hosting containers (bind mount) or a volume name. | ||
| `ACCESS_MODE` MAY be set as read-only by using `ro` or read and write by using `rw` (default). | ||
| `ACCESS_MODE` is a comma-separated `,` list of options and MAY be set as read-only by using `ro`, |
Collaborator
There was a problem hiding this comment.
Could you please turn it into bullet points (or otherwise break it up) for better readability?
Changed information about volume options from multi sentences long description to bullet list of options for better readability. Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
ndeloof
approved these changes
Jan 7, 2022
Contributor
Author
|
@EricHripko I like it 🔥 I have changed to bullet list as suggested in this commit f9ca0f6. I think it looks more readable now in that way. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Related with compose-spec/compose-go#213
This feature describe the SELinux field for setting the
:zor:Zbind option for relabeling SELinux label.References:
Which issue(s) this PR fixes:
Fixes #191
Signed-off-by: Tymoteusz Blazejczyk tymoteusz.blazejczyk@tymonx.com