Add missing deploy.limits.pids (from schema 3.9), deprecate pids_limit#214
Conversation
compose schema v3.9 added support for `deploy.limits.pids` (through docker/cli@851eeb9), however, work on compose-spec was already in progress, which lead to changes from the 3.9 schema to not be included. This patch adds the missing option and mars the `services.{name}.pids_limit` as deprecated, similar to comparable limit- and reservation options (`services.{name}.cpus`, `services.{name}.mem_limit`, `services.{name}.mem_reservation`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
EricHripko
left a comment
There was a problem hiding this comment.
Looks good ✅ Thank you for sorting this inconsistency out!
|
@thaJeztah Quick irrelevant question:
Where is this documented? I mean, I spent hours researching spec details and I couldn't find a single doc (except https://docs.docker.com/compose/compose-file/compose-file-v3/ which defines all versions as "legacy") about differences between different schema versions. |
|
I believe Docker now includes the spec in their official docs 🤓 |
|
@EricHripko As far as I remember it's been around for a while. The problem is it's not clear which spec is supported / implemented and what are the differences between different versions. |
|
I agree with you 👍 We talked about having MDN-like badges or compatibility tables in the past but never actually gotten around to implementing that in the spec. I think it's something worth revisiting. |
What this PR does / why we need it:
compose schema v3.9 added support for
deploy.limits.pids(through docker/cli@851eeb9 (docker/cli#2503)), however, work on compose-spec was already in progress, which lead to changes from the 3.9 schema to not be included.This patch adds the missing option and mars the
services.{name}.pids_limitas deprecated, similar to comparable limit- and reservation options (services.{name}.cpus,services.{name}.mem_limit,services.{name}.mem_reservation.relates to moby/moby#43056