rename "if_not_present" to "missing" to align with docker CLI#136
Merged
gtardif merged 2 commits intocompose-spec:masterfrom Jan 29, 2021
Merged
rename "if_not_present" to "missing" to align with docker CLI#136gtardif merged 2 commits intocompose-spec:masterfrom
gtardif merged 2 commits intocompose-spec:masterfrom
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
gtardif
approved these changes
Jan 28, 2021
aiordache
approved these changes
Jan 29, 2021
This was referenced Jun 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
rename the "if_not_present" pull_policy value as "missing" to align with docker CLI which
introduced
--pullflag independently:As if_not_present is kubernetes value for equivalent field and has been set months ago I don't think we should just rename, so the spec declares this value and alias implementations SHOULD accept.
Which issue(s) this PR fixes:
Fixes docker-archive/compose-cli#1183 (review)