Skip to content

Fix models support with compose include #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glours merged 1 commit into from
Oct 28, 2025
Merged

Fix models support with compose include #828

glours merged 1 commit into from
Oct 28, 2025

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Oct 28, 2025

based on #824

@ndeloof
Fix models support with compose include
913b951 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
glours approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit a91b45c into compose-spec:main Oct 28, 2025
8 checks passed
@doringeman
Copy link

doringeman commented Oct 28, 2025

Thank you!
So does this fix running docker-compose up with the root docker-compose.yml in docker/hello-genai#15?

@doringeman
Copy link

doringeman commented Oct 28, 2025

It doesn't, I still get:

$ docker compose up
validating /Users/doringeman/workspace/hello-genai/docker-compose.yml: services.go-genai.models.llama must be a mapping

@ndeloof ndeloof deleted the merge_model branch October 28, 2025 09:11
@ndeloof
Copy link
Collaborator Author

ndeloof commented Oct 28, 2025

@doringeman need to bump compose-go dependency in docker/compose

@doringeman
Copy link

doringeman commented Oct 28, 2025

@ndeloof I did that.

$ go mod edit -replace=github.com/compose-spec/compose-go/v2=github.com/compose-spec/compose-go/v2@45305bfca8aa1a17d3ec9e2b6421113db17cfa7b && go mod tidy && make install

$ ./bin/build/docker-compose version
Docker Compose version v2.23.3-950-ga07f2b8de.m

$ docker compose version
Docker Compose version v2.23.3-950-ga07f2b8de.m

$ docker compose up
validating /Users/doringeman/workspace/hello-genai/docker-compose.yml: services.node-genai.models.llama must be a mapping

Maybe the way that Compose files are written are not supposed to work?

@ndeloof
Copy link
Collaborator Author

ndeloof commented Oct 28, 2025 •
edited
Loading

@doringeman indeed
see #829

tested with:

replace github.com/compose-spec/compose-go/v2 => github.com/ndeloof/compose-go/v2 v2.0.1-0.20251028111733-3b4552469c27

@doringeman
Copy link

doringeman commented Oct 29, 2025

@ndeloof Yes, it works now, thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glours glours glours approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndeloof @doringeman @glours