Skip to content

Conversation

@lionello
Copy link
Contributor

@lionello lionello commented Jun 5, 2025

This PR updates go-yaml to the new official fork in the Yaml org, https://github.com/yaml/go-yaml

@lionello lionello requested a review from ndeloof as a code owner June 5, 2025 17:43
@lionello lionello force-pushed the update-go-yaml branch 3 times, most recently from 4f4e64e to 76c13f5 Compare June 5, 2025 17:50
@ndeloof
Copy link
Collaborator

ndeloof commented Jun 5, 2025

Oh nice, didn't know this fork exists. I tried migrating to goccy/go-yaml but this has significant impact

Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours
Copy link
Collaborator

glours commented Jul 3, 2025

Hello @lionello
It seems there is some conflicts to be resolved before we can merge the PR, can you handle this?
Screenshot 2025-07-03 at 10 41 35

Signed-off-by: Lionello Lunesu <lio+git@lunesu.com>
@lionello
Copy link
Contributor Author

lionello commented Jul 15, 2025

It seems there is some conflicts to be resolved before we can merge the PR, can you handle this?

Done! Please check @glours @ndeloof

@glours glours merged commit 5f04daa into compose-spec:main Jul 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants