Skip to content

detect project dir is a symlink and warn user#702

Merged
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:symlink
Oct 24, 2024
Merged

detect project dir is a symlink and warn user#702
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:symlink

Conversation

@ndeloof
Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof commented Oct 24, 2024

when ran from a symlink, while we find compose.yaml we run with a distinct project_dir and project_name. This might be user intent but also can cause unexpected behavior. This PR adds a sanity-check for such circumstances to warn user

closes docker/compose#12026

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from glours and jhrotko October 24, 2024 10:03
Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit bff5006 into compose-spec:main Oct 24, 2024
@ndeloof ndeloof deleted the symlink branch October 24, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] docker compose exec fails when projectdir is a symlink

2 participants