Skip to content

normalize volume.target to drop trailing slash #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndeloof merged 1 commit into from
Oct 15, 2024
Merged

normalize volume.target to drop trailing slash #697

ndeloof merged 1 commit into from
Oct 15, 2024

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Oct 14, 2024

No description provided.

@ndeloof ndeloof mentioned this pull request Oct 14, 2024
Merged
@ndeloof ndeloof requested review from glours and jhrotko October 14, 2024 09:59
jhrotko
jhrotko approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we moved the clean path to compose-go and cleaned up from compose in order to avoid inconsistensies?

@ndeloof
Copy link
Collaborator Author

ndeloof commented Oct 14, 2024

in docker/compose we ran volume.Target = path.Clean(volume.Target) within a func

  1. this was buggy as caller value was left unchanged (would need to pass a pointer)
  2. this is unsafe we "fix" the model inside some unrelated subfunction
    with this change, we get volume target cleaned after model is loaded, so we can safely compare values.

@ndeloof
normalize volume.target to drop trailing slash
24d6623 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof force-pushed the clean_volume_target branch from dfdad2e to 24d6623 Compare October 15, 2024 07:13
@ndeloof ndeloof marked this pull request as ready for review October 15, 2024 07:13
@ndeloof ndeloof enabled auto-merge (rebase) October 15, 2024 07:13
@ndeloof ndeloof merged commit 97c49fc into compose-spec:main Oct 15, 2024
@ndeloof ndeloof deleted the clean_volume_target branch December 1, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhrotko jhrotko jhrotko approved these changes

@glours glours Awaiting requested review from glours

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndeloof @jhrotko