introduce ability to use custom env_file format #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36e1834 to
2d728e7
Compare
cdb140d to
2e66a7c
Compare
jhrotko
requested changes
Oct 2, 2024
Collaborator
jhrotko
left a comment
There was a problem hiding this comment.
LGTM! I would also add/change a test in loader to also cover this case
types/project.go
Outdated
| fileVars, err = dotenv.ParseWithLookup(file, resolve) | ||
| } | ||
| if err != nil { | ||
| return nil, nil |
Collaborator
There was a problem hiding this comment.
Suggested change
| return nil, nil | |
| return nil, err |
Collaborator
Author
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to register additional env_file format parser, so one can plug https://github.com/docker/cli/blob/master/opts/envfile.go as an alternate parser, to support reading "raw" env_file just like
docker run --env-filedoes.