Add option to keep empty environment variable keys in normalization#634
Closed
edwardrf wants to merge 3 commits intocompose-spec:mainfrom
Closed
Add option to keep empty environment variable keys in normalization#634edwardrf wants to merge 3 commits intocompose-spec:mainfrom
edwardrf wants to merge 3 commits intocompose-spec:mainfrom
Conversation
Collaborator
|
please clarify your use case. a key-only environment variable is resolved based on user's environment, and ignored otherwise. Why not just populate the project environment with all usable values ? |
Author
|
We use the key-only environment variable in 2 ways:
The current behaviour of silently dropping them prevented us from doing either. An alternative solution is to return the dropped keys via a different way, like another return value or structured warning message. |
Author
|
Any suggestions? I am open to an alternative approach if there is a recommendation. |
Collaborator
|
Actually this is a bug to remove empty variable from container environment, as empty has a special meaning to "remove" variable (see docker/compose#11962) |
Collaborator
|
Closing as #654 has been merged |
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #589, the normalisation logic strips off any environment variables that does not have a value in config, however, i my use case, I am still interested in any empty environment variables names that has been set, which i'll resolve the value at a later stage, so I am implementing an naive option to allow me keep them during normalisation, please let me know if there is a better way of doing it. Currently, I have to load the project twice, use the one without normalisation to detect those empty environment variables.