remove constraint for container_name unicity while loading model#619
Merged
ndeloof merged 1 commit intocompose-spec:mainfrom Apr 16, 2024
Merged
remove constraint for container_name unicity while loading model#619ndeloof merged 1 commit intocompose-spec:mainfrom
ndeloof merged 1 commit intocompose-spec:mainfrom
Conversation
arunk-r
approved these changes
Apr 11, 2024
milas
approved these changes
Apr 16, 2024
Member
milas
left a comment
There was a problem hiding this comment.
It's unfortunate to lose this validation here but I don't see a better alternative right now :(
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
such validation should occur later, as we actually select containers to be created
see docker/compose#11619 (comment) for context