neutralize path separator when used in service name#522
Merged
ndeloof merged 1 commit intocompose-spec:mainfrom Jan 15, 2024
Merged
neutralize path separator when used in service name#522ndeloof merged 1 commit intocompose-spec:mainfrom
ndeloof merged 1 commit intocompose-spec:mainfrom
Conversation
Collaborator
Author
|
a nicer approach is to redefine update: we need tree.Path to be comparable so it can be used as map key, which makes this non-trivial :P |
f0e323b to
0129f49
Compare
|
👻 funny touch |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
0129f49 to
13df5ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tree.Pathmust distinguish parts in a path vs names using the path separator char.This quick fix replaces path separator with another char I don't expect anyone would use for resource name
closes docker/compose#11336