allow tmpfs.size to be set in unit bytes#192
Merged
ulyssessouza merged 1 commit intocompose-spec:masterfrom Sep 29, 2021
Merged
allow tmpfs.size to be set in unit bytes#192ulyssessouza merged 1 commit intocompose-spec:masterfrom
ulyssessouza merged 1 commit intocompose-spec:masterfrom
Conversation
mat007
reviewed
Sep 29, 2021
Comment on lines
+605
to
+610
| "capabilities": {"$ref": "#/definitions/list_of_strings"}, | ||
| "count": {"type": ["string", "integer"]}, | ||
| "device_ids": {"$ref": "#/definitions/list_of_strings"}, | ||
| "driver":{"type": "string"}, | ||
| "options":{"$ref": "#/definitions/list_or_dict"} | ||
| }, |
Contributor
There was a problem hiding this comment.
Indentation seems to be 2 characters in the rest of the file, was this change intended?
Collaborator
Author
There was a problem hiding this comment.
I copied the exact content from compose-spec - we haven't yet found a way to directly refer to the reference repository for this file
Contributor
There was a problem hiding this comment.
Maybe a JSON linter and the same approach as we use on V1, which is to integrate the download of the spec file in the build.
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This was referenced Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see compose-spec/compose-spec#205
Close docker/compose#8696