Allow custom decorators to be anywhere in the decorator chain#872
Allow custom decorators to be anywhere in the decorator chain#872juanmendes wants to merge 1 commit intocompodoc:developfrom
Conversation
Code was previously only looking at the first decorator. Fix is to make sure we scan all decorators before giving up and returning default class data. Closes# 868
Testing Done:Made sure that both and output the inputsClass in the exported JSON |
|
I realize this doesn't have any tests and I would like to write some but it's unclear where the test should go. I thought I could do:
@vogloblinsky can you please advise? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@vogloblinsky Adding a note to keep this from going stale since I got a notification that this had been marked as stale. Is compodoc still taking PRs? |
|
@antontemchenko Any way you can give me some guidance on how to write tests for this? As I mentioned, I couldn't find the best place to do this |
|
@vogloblinsky I has been over 4 months since I create this PR. Can you comment on whether this can be merged? Also, if tests are needed, where they should go? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had recent activity. Please file a new issue if you are encountering a similar or related problem. Thank you for your contributions. |
|
This is very much a problem. And this seems to fix it. @antontemchenko @vogloblinsky or anyone else who has merge privileges can this be merged? |
Code was previously only looking at the first decorator. Fix is
to make sure we scan all decorators before giving up and returning
default class data.
Closes #868