Conversation
c8416d1 to
b2f0e78
Compare
- Extract decorator type checking into generic hasDecoratorType() method - 5 separate methods now delegate to single implementation (44% reduction) - Extract JSDoc tags processing into processJSDocTags() helper - Used by 9 methods, eliminates 70 lines of duplication (97% reduction) - Extract JSDoc comment extraction into extractAndProcessJSDocComment() - Used by 8 methods, eliminates 39 lines of duplication (97% reduction) - Extract documentation field initialization into initializeDocumentationFields() - Used by 9 methods, eliminates 15 lines of duplication (94% reduction) Overall reduction: - Total lines saved: 144 lines (83% of duplicated code) - File size reduced: 1715 → 1595 lines (120 lines, 7% overall) - Duplication rate: 16% → 8-10% (50% reduction) - Methods refactored: 10+ - New helper methods: 4 Benefits: - Improved maintainability: changes only need to be made in one place - Better consistency: all methods follow same patterns - Reduced bug risk: centralized logic prevents inconsistencies - Enhanced readability: less boilerplate code - Easier testing: helper methods independently testable All functionality preserved, build successful, zero breaking changes.
Collaborator
Author
|
@vogloblinsky I need some help solving the problem with the build in Sonarcloud. |
Contributor
|
@tcorral i changed the default quality gate of compodoc in sonar to a custom one with "Coverage | is less than | 20.0%" |
Contributor
|
@tcorral Code coverage config updated on main branch |
vogloblinsky
approved these changes
Jan 12, 2026
Contributor
vogloblinsky
left a comment
There was a problem hiding this comment.
Perfect, thanks for the work
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix Type Alias Links in Method Signatures
Fixes: #1542
Problem
Type aliases in method signatures generated incorrect links to
../undefineds/TypeName.htmlinstead of../miscellaneous/typealiases.html#TypeName.Solution
Updated
function-signature.helper.tsto properly handle miscellaneous types (type aliases, enums, functions, variables) by checking bothtypeandctypeproperties and mapping subtypes to correct documentation pages.Changes
Modified:
src/app/engines/html-engine-helpers/function-signature.helper.tshelperFunc()andhandleFunction()methodsAdded: Regression tests (9 tests, all passing)
test/src/cli/cli-type-alias-in-signatures.spec.tstest/fixtures/todomvc-ng2/src/app/shared/models/type-alias-in-signature.model.tsTest Results
✅ 646 tests passing (includes 9 new regression tests)
✅ No breaking changes
✅ All test cases verify correct link generation and absence of undefined links