Conversation
- Added error handling for JSON5 parsing in the cleanRawRouteParsed method to log detailed error messages when parsing fails due to special characters in file paths or route configurations. - Improved the cleanRawRoute method to handle unescaped characters and malformed string concatenations that could lead to parsing issues. - Introduced a new test suite to validate the handling of routes with special characters, ensuring that documentation generation does not fail due to these issues. We do expect these changes to fix all the JSON5 parsing errors: #1610, #1594, #1581, #1573 and #1550
Collaborator
Author
|
@vogloblinsky Could you help with the false positive? https://sonarcloud.io/project/security_hotspots?sinceLeakPeriod=true&pullRequest=1611&id=compodoc_compodoc I cannot set them as safe. |
…RouterParserUtil - Enhanced the RouterParserUtil to correctly parse template literals and fix issues with malformed string concatenations. - Updated tests to validate the handling of new template literal routes and ensure that JSON5 parsing errors are properly managed. - Ensured that the application does not crash with complex character combinations in routes, addressing new edge cases. These changes aim to resolve additional parsing issues related to template literals and improve overall robustness in route handling.
Contributor
I just mark them as safe |
vogloblinsky
approved these changes
Aug 29, 2025
Contributor
vogloblinsky
left a comment
There was a problem hiding this comment.
Perfect, thanks for the work
added 3 commits
August 29, 2025 15:28
- Updated the route rendering logic to handle cases where the component name is not provided, defaulting to the path or name. - Added conditional checks to display the component name when it includes 'Component' for better clarity in the output. - Enhanced the overall robustness of the route display by ensuring that both path and name are utilized effectively. These changes aim to improve the user experience by providing clearer route information in the application.
…for application - Introduced a new routing module (AppRoutingModule) to manage application routes, including dynamic and nested routes. - Created constants for route paths and types to enhance route management and clarity. - Added utility functions for lazy loading modules and route configuration. - Established a basic application module (AppModule) to bootstrap the application with routing capabilities. - Included a TypeScript configuration file for improved type checking and compilation settings. These changes lay the groundwork for a structured routing system, improving navigation and modularity within the application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do expect these changes to fix all the JSON5 parsing errors: #1610 , #1594 , #1581 , #1573 #1550 and #1533