refactor: update CLI options to use COMPODOC_DEFAULTS for default values#1607
Merged
refactor: update CLI options to use COMPODOC_DEFAULTS for default values#1607
Conversation
added 2 commits
August 27, 2025 13:31
This commit modifies the CLI application to utilize the COMPODOC_DEFAULTS object for default values of various options, ensuring consistency and easier management of default settings. The changes include updating options for silent mode, serving, watching, and several other flags to reference the defaults defined in the defaults.ts file.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CLI application to centralize default values by utilizing the COMPODOC_DEFAULTS object instead of hardcoded values throughout the CLI options. This improves maintainability by having a single source of truth for default settings.
Key changes:
- Added new default values to the COMPODOC_DEFAULTS object (disableSearch, hideGenerator, hideDarkModeToggle, minimal, silent, serve, watch)
- Updated CLI option definitions to reference COMPODOC_DEFAULTS instead of hardcoded false values
- Ensured consistency across all CLI options by using centralized default management
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/defaults.ts | Added missing default values for CLI options that were previously hardcoded |
| src/index-cli.ts | Updated CLI option definitions to use COMPODOC_DEFAULTS instead of hardcoded values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the CLI application to utilize the COMPODOC_DEFAULTS object for default values of various options, ensuring consistency and easier management of default settings. The changes include updating options for silent mode, serving, watching, and several other flags to reference the defaults defined in the defaults.ts file.