feat(app): better handle multiple types, default values, and options for input/output/model signals#1526
Merged
vogloblinsky merged 5 commits intocompodoc:developfrom Nov 12, 2024
Conversation
…for input/output/model signals
Contributor
|
Hi, |
…nal inputs/outputs/models
Contributor
Author
|
Hi @vogloblinsky, I've added some (admittedly very messy) tests and made sure the signal's default values/types also work with periods and underscores . |
|
@bameyrick great work! @vogloblinsky I'm not sure whether compodoc has a release schedule. |
Contributor
|
I am on it, this week ;) |
|
@vogloblinsky I guess you're busy, any update on the release? |
Contributor
|
@vogloblinsky Any chance of getting this fix released soon? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the work in #1439 to:
input('value', { transform: (value) => value.toLowerCase() })input<string | number>(),input<'button' | 'reset'>()This doesn't fully address some of the comments in #1439 to use babel, however it should handle more cases for input/output/model signals.
Closes #1498