Improve ERM subtests#2004
Conversation
|
@ljharb Is this PR ready to merge? Thanks. |
| chrome140: false, | ||
| chrome141: true, | ||
| chrome143: true, | ||
| firefox141: true, |
There was a problem hiding this comment.
I tested with Firefox 115, it passed.
There was a problem hiding this comment.
This is very strange. The ERM implementation was landed in FF 134 behind a flag, which was then unflagged in FF 141. The test should not have passed in FF 115. I will check if there is something wrong in the test itself.
There was a problem hiding this comment.
Update: I can not reproduce the result on FF 115 mac version, all subtests fail as expected:
There was a problem hiding this comment.
My bad. I installed FF115 to run the test but it updated itself. I reinstalled it and got the same results as you.
There was a problem hiding this comment.
Thank you. Yeah the auto-update is pretty annoying for test purpose. I wish FF can offer a "Firefox for testing" build that always disables the auto-update.
8988d56 to
b3064fd
Compare
As a follow-up to #1999, this PR adds more support data to the test results.