Remove INSTALL_NAME_DIR target property

Francois Budin · jcfr · commit fa7c64767ecc · 2017-09-21T09:48:12.000-04:00
Using INSTALL_NAME_DIR target property forces the install name to be an absolute path instead of `@rpath/{target_name}` [1]. This causes problems when one tries to relocate the target once it is installed. This patch removes this target property. If a project needs to keep the absolute path, CMake variables such as INSTALL_NAME_DIR can be set at configuration to do so. [1] https://gitlab.kitware.com/cmake/cmake/issues/16589
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -309,14 +309,6 @@ add_library(PythonQt SHARED
   )
 set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS)
 
-#
-# That should solve linkage error on Mac when the project is used in a superbuild setup
-# See http://blog.onesadcookie.com/2008/01/installname-magic.html
-#
-set_target_properties(PythonQt  PROPERTIES
-  INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib"
-  )
-
 target_compile_options(PythonQt PRIVATE
   $<$<CXX_COMPILER_ID:MSVC>:/bigobj>
   )

Original file line number	Diff line number	Diff line change
`@@ -309,14 +309,6 @@ add_library(PythonQt SHARED`
`309`	`309`	`)`
`310`	`310`	`set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS)`
`311`	`311`
`312`		`-#`
`313`		`-# That should solve linkage error on Mac when the project is used in a superbuild setup`
`314`		`-# See http://blog.onesadcookie.com/2008/01/installname-magic.html`
`315`		`-#`
`316`		`-set_target_properties(PythonQt PROPERTIES`
`317`		`- INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib"`
`318`		`- )`
`319`		`-`
`320`	`312`	`target_compile_options(PythonQt PRIVATE`
`321`	`313`	`$<$<CXX_COMPILER_ID:MSVC>:/bigobj>`
`322`	`314`	`)`