Skip to content

Don't trim non-ASCII whitespace #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgm merged 1 commit into from
Sep 23, 2024
Merged

Don't trim non-ASCII whitespace #289

jgm merged 1 commit into from
Sep 23, 2024

Conversation

@tats-u
Copy link
Contributor

@tats-u tats-u commented Sep 8, 2024 •
edited
Loading

Fixes #261

.trim() removes non-ascii Unicode white spaces as well.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim

PS D:\cmark\out\install\x64-Debug\bin> .\cmark.exe
　全角スペース (U+3000) 全形空白　

 Em Space (U+2003) Em Space 

 NBSP (U+00A0) NBSP
^Z
<p>　全角スペース (U+3000) 全形空白　</p>
<p>?Em Space (U+2003) Em Space?</p>
<p>NBSP (U+00A0) NBSP</p>

cmark removes NBSP, but is this an expected behavior?
(? means U+2003 can't be converted to Shift_JIS, which is the OEM encoding in Japanese Windows.)

@tats-u tats-u mentioned this pull request Sep 23, 2024
Open
@tats-u tats-u force-pushed the trim-only-ascii-space branch 2 times, most recently from 21d88d5 to 32e9f5c Compare September 23, 2024 10:40
@tats-u tats-u force-pushed the trim-only-ascii-space branch from 32e9f5c to 2428626 Compare September 23, 2024 13:27
@jgm jgm merged commit f3145e8 into commonmark:master Sep 23, 2024
@tats-u tats-u deleted the trim-only-ascii-space branch September 23, 2024 22:35
@tats-u tats-u mentioned this pull request Sep 24, 2024
Merged
4 tasks
This was referenced Nov 27, 2024
Open
Open
@tats-u tats-u mentioned this pull request Dec 13, 2024
Merged
@tats-u tats-u mentioned this pull request Sep 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

U+3000 (　) is allowed as paragraph indentation

2 participants

@tats-u @jgm