Skip to content

Fix HTML comment parsing with - before closing --> #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgm merged 2 commits into from
Mar 6, 2024
Merged

Fix HTML comment parsing with - before closing --> #286

jgm merged 2 commits into from
Mar 6, 2024

Conversation

@robinst
Copy link
Contributor

@robinst robinst commented Mar 3, 2024

Fixes #285.

@jgm
Copy link
Member

jgm commented Mar 3, 2024

Looks good. Would it be worth adding a test like

<!-- foo --> more -->

@robinst
Copy link
Contributor Author

robinst commented Mar 5, 2024

Good idea, added foo <!-- test --> more --> now (to enforce inline processing instead of block).

@jgm jgm merged commit 6f94a99 into commonmark:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTML comment handling doesn't match spec 0.31.2?

2 participants

@robinst @jgm