Skip to content

Better identify repo licenses#487

Merged
mr-c merged 2 commits intomainfrom
better-license-identification
Jan 1, 2023
Merged

Better identify repo licenses#487
mr-c merged 2 commits intomainfrom
better-license-identification

Conversation

@GlassOfWhiskey
Copy link
Collaborator

@GlassOfWhiskey GlassOfWhiskey commented Dec 31, 2022

Description

This commit introduces calls to Ruby Licensee Gem to better identify licenses in the Git repos. In particular, whenever Licensee is able to identify the license, the license_link field is populated with the SPDX URL of the corresponding license.

Motivation and Context

License details are fundamental to ensure proper data usage policies.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c December 31, 2022 14:54
@GlassOfWhiskey GlassOfWhiskey force-pushed the better-license-identification branch from 52c6272 to c35aa0e Compare December 31, 2022 15:29
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests, please 😀

@GlassOfWhiskey GlassOfWhiskey force-pushed the better-license-identification branch 3 times, most recently from 744566e to e269f1a Compare December 31, 2022 16:21
@GlassOfWhiskey GlassOfWhiskey force-pushed the better-license-identification branch 5 times, most recently from 0fdefb5 to f66942c Compare January 1, 2023 09:53
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(the changelog also needs updating)

@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c January 1, 2023 17:10
@mr-c mr-c force-pushed the better-license-identification branch 2 times, most recently from 1224308 to c9b04ad Compare January 1, 2023 17:40
This commit introduces calls to GitHub and GitLab APIs to better
identify licenses in the Git repos. In particular, whenever the Git
provider service is able to identify the license, the license_link field
is populated with the SPDX URL of the corresponding license.
@GlassOfWhiskey GlassOfWhiskey force-pushed the better-license-identification branch from 89e20ff to 2b95f08 Compare January 1, 2023 17:52
@GlassOfWhiskey GlassOfWhiskey force-pushed the better-license-identification branch from 2b95f08 to fceb8ad Compare January 1, 2023 18:01
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No kill

@mr-c mr-c merged commit c78f24c into main Jan 1, 2023
@mr-c mr-c deleted the better-license-identification branch January 1, 2023 18:41
@GlassOfWhiskey GlassOfWhiskey mentioned this pull request Jan 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants