Skip to content

Update spring boot, liquibase, jgit#413

Merged
mr-c merged 3 commits intocommon-workflow-language:mainfrom
kinow:update-dependencies
May 16, 2022
Merged

Update spring boot, liquibase, jgit#413
mr-c merged 3 commits intocommon-workflow-language:mainfrom
kinow:update-dependencies

Conversation

@kinow
Copy link
Member

@kinow kinow commented May 11, 2022 •
edited
Loading

Description

Updating dependencies, and building the project now with Java 17 (LTS). Had to replace Cobertura by JaCoCo in order to get the build green. The test coverage reduced, but that's because Cobertura was reporting incorrectly (see comment below about it).

Motivation and Context

Proactively updating a few dependencies.

How Has This Been Tested?

  • mvn clean test
  • Running Docker Compose locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mr-c
Copy link
Member

mr-c commented May 12, 2022

https://github.com/common-workflow-language/cwlviewer/runs/6405459959?check_suite_focus=true#step:6:384

Time to upgrade to something newer than Java 8?

@kinow
Copy link
Member Author

kinow commented May 12, 2022

https://github.com/common-workflow-language/cwlviewer/runs/6405459959?check_suite_focus=true#step:6:384

Time to upgrade to something newer than Java 8?

Good idea. Probably latest LTS 17 if it works with our dependencies & deployment - https://www.oracle.com/java/technologies/java-se-support-roadmap.html

@kinow kinow force-pushed the update-dependencies branch 6 times, most recently from 85414d7 to 1123a84 Compare May 14, 2022 11:44
@kinow kinow force-pushed the update-dependencies branch from 1123a84 to 2c002ab Compare May 14, 2022 11:52
@kinow
Copy link
Member Author

kinow commented May 14, 2022 •
edited
Loading

Upgraded to Java 17, then had to update Docker and then the build tooling too. Upgraded the maven plug-ins, it broke coverage. Fixed coverage, now the report is complaining it was reduced in 7.1 % 😅 Almost there! More tomorrow.

This PR is also using a newer Docker image. I expect it to use newer versions of libraries, fixing issues reported in other linters/CI services.

@kinow
Copy link
Member Author

kinow commented May 14, 2022

image

image

There are way more files in the JaCoCo report than in the Cobertura one. And Cobertura appears to have been broken for a while. I confirmed GitDetails.java that was 100% for Cobertura is not actually fully covered by our tests. So the JaCoCo number looks correct 👍

@kinow kinow marked this pull request as ready for review May 14, 2022 23:31
@kinow kinow requested review from mr-c and tetron May 14, 2022 23:34
@kinow kinow mentioned this pull request May 16, 2022
Merged
@kinow
Copy link
Member Author

kinow commented May 16, 2022

@mr-c updated the branch, but I cannot merge it, could you merge it if it's looking OK to you, please? Thanks!!! 🙏

image

@kinow
Copy link
Member Author

kinow commented May 16, 2022

Coverage will go down due to a problem at how Cobertura was counting covered code. But we will increase that later 💪

@mr-c mr-c merged commit 4428e23 into common-workflow-language:main May 16, 2022
@kinow kinow deleted the update-dependencies branch May 16, 2022 12:11
@mr-c mr-c mentioned this pull request Dec 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mr-c mr-c mr-c approved these changes

@tetron tetron Awaiting requested review from tetron

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kinow @mr-c