Use Yaml SafeConstructor to prevent serialization issues#355
Merged
mr-c merged 1 commit intocommon-workflow-language:mainfrom Sep 30, 2021
Merged
Use Yaml SafeConstructor to prevent serialization issues#355mr-c merged 1 commit intocommon-workflow-language:mainfrom
mr-c merged 1 commit intocommon-workflow-language:mainfrom
Conversation
|
This pull request fixes 1 alert when merging 71aeade into 7b8eb67 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 3e7b69f into 7b8eb67 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@mr-c I've successfully reproduced an issue with serialization. From the same page with the exploit, looks like passing the
SafeConstructorfixes it (it's a class provided by SnakeYaml that prevents certain things from being accessed when constructing objects.)Motivation and Context
Prevent serialization issues as reported in #241 (comment)
How Has This Been Tested?
Locally.
Screenshots (if appropriate):
Types of changes
Checklist:
Not sure how this could be tested 👍 static analyzers will spot the issue again (assuming the static analyzers are able to comprehend that
SafeConstructorfixes the issue)