Support for Git tags #191#192
Merged
stain merged 3 commits intocommon-workflow-language:masterfrom May 22, 2018
Merged
Conversation
If we get a RefNotFoundException, it might be a tag.
mr-c
previously requested changes
Apr 15, 2018
Member
mr-c
left a comment
There was a problem hiding this comment.
Looks great, can we get a test for this fix?
Had to introduce mockito as a (test) dependency. Refactored GitService a little to allow for mocks.
stain
approved these changes
May 22, 2018
| repo.checkout() | ||
| .setName(branchOrCommitId) | ||
| .call(); | ||
| try { |
Member
There was a problem hiding this comment.
Agree on the logic of trying branch before tag, that's the logic used at GitHub as well - see https://github.com/stain/branchandtagtest/blob/test/README.md where I tried to make a branch and a tag both called test (but the branch further ahead)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unless it was as commit id, GitService.java was always specifying
/refs/remotes/origin/<branch>for the name to checkout. This does not work with Git tags. See Stack Overflow. See if there is a If a RefNotFoundException fetching a branch, and if there is, try with the name only. If that also gives an error, thrown the original exception.Motivation and Context
This is to allow users to visualize CWL files that referenced by a Git tag. I ran into this doing the integration with Dockstore.org and CWLViewer.
Fixes #191
How Has This Been Tested?
I tested this manually, by running CWLViewer locally and entering workflows that had both branches and tags in their paths.
There are no existing unit tests in this area, and I did not add any new tests.
Types of changes
Checklist: