Merged
Conversation
.. also improve print view by hiding the interactive SVG and showing a static SVG
.. to make permalinks at bottom of page
also ignoring JSON due to #166
as bundle always uses / separator
MarkRobbo
approved these changes
Aug 31, 2017
Member
Author
|
Thanks, @MarkRobbo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the permalink on the workflow page.
Description
@media print- hide certain elements.Motivation and Context
#29 added permalinks, documented in https://github.com/common-workflow-language/cwlviewer/wiki/Permalinks and used within the Research Object manifest and its RDF.
However there should also be links to the particular permalink so it is Findable and bookmarkable.
An additional motivation would be to show direct links to the the different content negotiation formats using
?format=mechanism (as browsers would always use sameAcceptheader).How Has This Been Tested?
Tested locally with Chrome and Microsoft Edge on Windows 10 - tested responsive design using Chrome's debug mode.
Screenshots (if appropriate):
Types of changes
Checklist: