Skip to content

Show permalinks in HTML#175

Merged
stain merged 10 commits intomasterfrom
permalinks-ui
Sep 1, 2017
Merged

Show permalinks in HTML#175
stain merged 10 commits intomasterfrom
permalinks-ui

Conversation

@stain
Copy link
Member

@stain stain commented Aug 31, 2017

Add the permalink on the workflow page.

Description

  • Add a line with "Permalink: https://w3id.org/cwl/view/..."
  • Add format-specific permalink buttons at the bottom of the page
  • Improve responsive design and CSS @media print - hide certain elements.

Motivation and Context

#29 added permalinks, documented in https://github.com/common-workflow-language/cwlviewer/wiki/Permalinks and used within the Research Object manifest and its RDF.

However there should also be links to the particular permalink so it is Findable and bookmarkable.

An additional motivation would be to show direct links to the the different content negotiation formats using ?format= mechanism (as browsers would always use same Accept header).

How Has This Been Tested?

Tested locally with Chrome and Microsoft Edge on Windows 10 - tested responsive design using Chrome's debug mode.

Screenshots (if appropriate):

permalink-1
permalink-2
permalink-buttons

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stain stain merged commit 9929cfa into master Sep 1, 2017
@stain
Copy link
Member Author

stain commented Sep 1, 2017

Thanks, @MarkRobbo!

@stain stain deleted the permalinks-ui branch September 1, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants