setup.py: pin ruamel.yaml package version#450
Merged
Conversation
mr-c
reviewed
Jun 29, 2017
setup.py
Outdated
| 'setuptools', | ||
| 'requests >= 1.0', | ||
| 'ruamel.yaml >= 0.12.4', | ||
| 'ruamel.yaml >= 0.12.4, <= 0.15.2', |
Member
There was a problem hiding this comment.
Shouldn't they both be < 0.15 due to the API changes & warnings?
Member
Author
There was a problem hiding this comment.
I was using 0.15.2 due to some mypy updates which were released in this version, but yeah they didn't help much. I will change to ruamel.yaml<=0.15
Member
There was a problem hiding this comment.
just < please -- unless you need something from 0.15
set upper bound for ruamel.yaml version, same as schema_salad.
1531806 to
5c110c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set upper bound for ruamel.yaml version,
same as in schema_salad: https://github.com/common-workflow-language/schema_salad/blob/master/setup.py#L33