refactor(tool): use charset_normalizer instead of chardet#550
refactor(tool): use charset_normalizer instead of chardet#550woile merged 1 commit intocommitizen-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 39 39
Lines 1556 1556
=======================================
Hits 1529 1529
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
In the future I’d appreciate it if people communicate the duplicated effort, so that I don’t have to waste my time writing a PR only so it will be replaced by another. |
|
I think your change is still valid. It's worth changing the chardet library in this PR. But we can still have the same issue as before, or I'm missing something? Sorry for the inconvenience occasionated if so. |
|
Hi Jens, sorry but adding chardet comes from my PR and, after all the recent issues made by it, I felt unhappy so I’ve searched and tested an alternative. I hope it works, and probably could be useful to add some more tests to avoid regression. |
Description
move from chardet to charset_normalizer to avoid recent issue on wrong encoding.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
commitizen is able to decode command's strings without issue on
decode.Steps to Test This Pull Request
Additional context
#545
#544