Add tip to scroll up on package build failure. #5279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many users don't get that when they see an error like
-- While building package hopenssl-2.2.4 using:
they have to scroll up (potentially multiple terminal pages!)
to the last output starting with e.g. `hopenssl >`.
This adds an explicit call to scroll up to that section,
so that this user confusion can be reduced.
snoyberg
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users don't get that when they see an error like
they have to scroll up (potentially multiple terminal pages!) to the last output starting with e.g.
hopenssl >.This adds an explicit call to scroll up to that section, so that this user confusion can be reduced.
Please also shortly describe how you tested your change. Bonus points for added tests!
I haven't tested this at all because it's just a simple string change I made on a whim and hopw CI will do it for me :)