Skip to content

Changed importing comics to use server-side selections [#2489]#2514

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2489
Nov 5, 2025
Merged

Changed importing comics to use server-side selections [#2489]#2514
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2489

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Nov 5, 2025

  • Renamed sendComicFiles => importComicFiles.
  • Removed fields from the importComicFiles action.
  • Changed the backend to use the session's list of filenames.
  • Added resetting the comic file list on successful import start.

Closes #2489

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Updates runtime dependencies but does not add new functionality
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added this to the 3.1 milestone Nov 5, 2025
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Nov 5, 2025
@mcpierce
Changed importing comics to use server-side selections [comixed#2489]
78ba304 
 * Renamed sendComicFiles => importComicFiles.
 * Removed fields from the importComicFiles action.
 * Changed the backend to use the session's list of filenames.
 * Added resetting the comic file list on successful import start.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit 0453fab into comixed:main Nov 5, 2025
5 checks passed
@mcpierce mcpierce deleted the feature/issue-2489 branch November 5, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

Importing comics uses the server-side collection of files.

1 participant

@mcpierce