Skip to content

Added a type to ComicPage [#2475]#2479

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2475
Oct 11, 2025
Merged

Added a type to ComicPage [#2475]#2479
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2475

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Oct 11, 2025

  • Added the column to the comic_pages table.
  • Added changing the first comic_pages record to "FRONT_COVER".
  • Added changing the renaming comic_pages to "STORY".
  • Added an enumerated type to represent the value.
  • Added setting the default type to "STORY".
  • Added setting the first image imported to "FRONT_COVER".
  • Added showing the page type on the Comic Details -> Pages tab.

Closes #2475

Status

READY

Does this PR contain migrations?

YES

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Updates runtime dependencies but does not add new functionality
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added this to the 3.1 milestone Oct 11, 2025
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Oct 11, 2025
@mcpierce
Added a type to ComicPage [comixed#2475]
38ebfba 
 * Added the column to the comic_pages table.
 * Added changing the first comic_pages record to "FRONT_COVER".
 * Added changing the renaming comic_pages to "STORY".
 * Added an enumerated type to represent the value.
 * Added setting the default type to "STORY".
 * Added setting the first image imported to "FRONT_COVER".
 * Added showing the page type on the Comic Details -> Pages tab.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit 2ca9b38 into comixed:main Oct 11, 2025
5 checks passed
@mcpierce mcpierce deleted the feature/issue-2475 branch October 11, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

Comic pages have a type.

1 participant

@mcpierce