Skip to content

Changed page hash loading to work on whole comic books [#2433]#2435

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2433
Sep 13, 2025
Merged

Changed page hash loading to work on whole comic books [#2433]#2435
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2433

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Sep 13, 2025

  • Moved the classes to the .comicbooks package.
  • Renamed the classes to ProcessUnhashedComics

Also refactored AbstractComicBookReader and its children to move the ComicBookService reference into the parent class.

Closes #2433

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Updates runtime dependencies but does not add new functionality
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Changed page hash loading to work on whole comic books [comixed#2433]
26e995f 
 * Moved the classes to the .comicbooks package.
 * Renamed the classes to ProcessUnhashedComics

Also refactored AbstractComicBookReader and its children to move
the ComicBookService reference into the parent class.
@mcpierce mcpierce added this to the 3.0 milestone Sep 13, 2025
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Sep 13, 2025
@mcpierce mcpierce merged commit 14bbc41 into comixed:main Sep 13, 2025
2 checks passed
@mcpierce mcpierce deleted the feature/issue-2433 branch September 13, 2025 14:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 13, 2025

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

Loading page hashes should process whole comics as a unit.

1 participant

@mcpierce