Skip to content

Changed Junit dependency from 4 to 5 [#2350]#2354

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2350
Feb 22, 2025
Merged

Changed Junit dependency from 4 to 5 [#2350]#2354
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2350

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Feb 22, 2025

  • Removed dependency on Junit 4 vintage.
  • Changed repository tests to use SpringJunit4ClassRunner.
  • Fixed some issues identified by SonarQube.

Closes #2350

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Updates runtime dependencies but does not add new functionality
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Changed Junit dependency from 4 to 5 [comixed#2350]
04b3ce9 
 * Removed dependency on Junit 4 vintage.
 * Changed repository tests to use SpringJunit4ClassRunner.
 * Fixed some issues identified by SonarQube.
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Feb 22, 2025
@mcpierce mcpierce added this to the 2.4 milestone Feb 22, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 22, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit bb6bae2 into comixed:main Feb 22, 2025
4 of 5 checks passed
@mcpierce mcpierce deleted the feature/issue-2350 branch February 22, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate unit tests to JUnit 5.

1 participant

@mcpierce