Skip to content

Added the DisplayableComic type for displayable comics [#2292]#2295

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2292
Jan 11, 2025
Merged

Added the DisplayableComic type for displayable comics [#2292]#2295
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2292

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Jan 9, 2025

  • Added a view to load the data into the object.
  • Added an example builder for the new type.
  • Added backend services to load the new type.
  • Added a frontend feature to load the new type.
  • Removed the old comic detail list feature.

Status

HOLD

Does this PR contain migrations?

YES

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Jan 9, 2025
@mcpierce mcpierce added this to the 2.3 milestone Jan 9, 2025
@mcpierce mcpierce force-pushed the feature/issue-2292 branch 3 times, most recently from 4ccd824 to 96cb566 Compare January 11, 2025 21:04
@mcpierce
Added the DisplayableComic type for displayable comics [comixed#2292]
b2b21b5 
 * Added a view to load the data into the object.
 * Added an example builder for the new type.
 * Added backend services to load the new type.
 * Added a frontend feature to load the new type.
 * Removed the old comic detail list feature.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 11, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit 9af2ab4 into comixed:main Jan 11, 2025
3 of 4 checks passed
@mcpierce mcpierce deleted the feature/issue-2292 branch January 11, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

1 participant

@mcpierce