Skip to content

Changed moving comics to be more efficient [#2290]#2291

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2290
Jan 5, 2025
Merged

Changed moving comics to be more efficient [#2290]#2291
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2290

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Jan 5, 2025

  • Changed the batch class package: batch.comicbooks => batch.library
  • Added a domain type for the batch process: OrganizingComic
  • Added a view to load organizing comic books.

Closes #2290

Status

READY

Does this PR contain migrations?

YES

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Jan 5, 2025
@mcpierce mcpierce added this to the 2.3 milestone Jan 5, 2025
@mcpierce
Changed moving comics to be more efficient [comixed#2290]
0269052 
 * Changed the batch class package: batch.comicbooks => batch.library
 * Added a domain type for the batch process: OrganizingComic
 * Added a view to load organizing comic books.
@mcpierce mcpierce force-pushed the feature/issue-2290 branch from 2f64484 to 0269052 Compare January 5, 2025 15:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
83.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit 3847263 into comixed:main Jan 5, 2025
@mcpierce mcpierce deleted the feature/issue-2290 branch January 5, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

Moving comic books is more performant.

1 participant

@mcpierce