Add support for GTIN identifier #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordwelch
requested changes
May 22, 2025
Member
lordwelch
left a comment
There was a problem hiding this comment.
The reading of the GTIN is implementation-dependant, so I figured a large text box would be fitting since one could use it with multiple identifiers at once (isbn:xxxxxx,ean:yyyyy,bookid:zzzzz).
FYI, the gtin doesn't actually support multiple values and shouldn't have the type prepended.
I have one change needed with the comicrack.py
and a suggestion in taggerwindow.py
lordwelch
approved these changes
May 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first public contribution ever, so please bear with me.
I've added support for the GTIN tag to represent the EAN/ISBN, as specified in https://anansi-project.github.io/fr/docs/comicinfo/documentation#gtin
Related issue: #761
No tests were added, but one had to be changed to include the new identifier.
The text field is at the bottom of the Details page.
The reading of the GTIN is implementation-dependant, so I figured a large text box would be fitting since one could use it with multiple identifiers at once (isbn:xxxxxx,ean:yyyyy,bookid:zzzzz).